gh-122449: Use constants instead of hard-coded strings in Tools/cases_generator
#122448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tools/cases_generatorTools/cases_generator
sobolevn
reviewed
Jul 30, 2024
…-kind # Conflicts: # Tools/cases_generator/analyzer.py # Tools/cases_generator/generators_common.py
sobolevn
reviewed
Nov 15, 2024
sobolevn
reviewed
Nov 16, 2024
|
@markshannon Are you interested in this kind of refactoring or not? if not, I'll close this one. (since you're mostly working in that area, your fingers may remember what to type so this PR could not be useful to you) |
|
Closing since this didn't attract enough attention. The work can always be restored later but conflicts are still annoying to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR for avoiding using hardcoded token's kind. By the way, I observed something weird: In
always_exitsofanalyzer.pywe havecpython/Tools/cases_generator/analyzer.py
Lines 537 to 542 in d27a53f
but a token kind set to "KEYWORD" does not exist (I added the constant but did not use it at all and I don't know how you could create one of that kind). I assume that the test should instead be something like
tkn.kind in lx.keywords.values()instead but I would like confirmation on that matter.I did not touch the kind of a Node since they are already literals (and mypy would then comply if something is wrong).
Tools/cases_generator#122449