Skip to content

[3.13] gh-100256: Skip inaccessible registry keys in the WinAPI mimetype implementation (GH-122047) #122786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 7, 2024

…pe implementation (pythonGH-122047)

(cherry picked from commit 0bd9375)

Co-authored-by: Lucas Esposito <LucasEsposito@users.noreply.github.com>
@zooba
Copy link
Member

zooba commented Aug 7, 2024

@Yhg1s Requesting consideration for rc2. This is an older issue, and will be fixed in 3.12 and 3.13.1 (if not sooner). It's silently suppressing a particular error code in a native port of a Python function - the equivalent error is suppressed in the Python function.

I didn't find any obvious posts about branch policy right now, but I'm assuming we need RM approval for post-RC changes? Though the branch is not locked.

@Yhg1s
Copy link
Member

Yhg1s commented Sep 2, 2024

I didn't find any obvious posts about branch policy right now, but I'm assuming we need RM approval for post-RC changes? Though the branch is not locked.

FWIW, there's no need for RM approval (because I've been somewhat busy quitting Google): https://discuss.python.org/t/3-13-branch-locked-for-the-rc1-release/59612

There's still the policy of requiring review on PRs to the branch, but it doesn't have to be RM review.

@Yhg1s Yhg1s merged commit f070398 into python:3.13 Sep 2, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants