Skip to content

GH-122821: Simplify compilation of while statements to ensure consistency of offsets for sys.monitoring #122934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2024
Merged

GH-122821: Simplify compilation of while statements to ensure consistency of offsets for sys.monitoring #122934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87e2bf8
Simplify compilation of while statements to ensure consistency of off…
markshannon Aug 12, 2024
4115a9a
Add use of variable for test
markshannon Aug 12, 2024
b55c413
Add test for branch consistency in while loop
markshannon Aug 12, 2024
4915647
Update Misc/NEWS.d/next/Core_and_Builtins/2024-08-12-11-45-47.gh-issu…
markshannon Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Include/internal/pycore_magic_number.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ Known values:
Python 3.14a1 3601 (Fix miscompilation of private names in generic classes)
Python 3.14a1 3602 (Add LOAD_SPECIAL. Remove BEFORE_WITH and BEFORE_ASYNC_WITH)
Python 3.14a1 3603 (Remove BUILD_CONST_KEY_MAP)
Python 3.14a1 3604 (Do not duplicate test at end of while statements)

Python 3.15 will start with 3650

Expand All @@ -267,7 +268,7 @@ PC/launcher.c must also be updated.

*/

#define PYC_MAGIC_NUMBER 3603
#define PYC_MAGIC_NUMBER 3604
/* This is equivalent to converting PYC_MAGIC_NUMBER to 2 bytes
(little-endian) and then appending b'\r\n'. */
#define PYC_MAGIC_NUMBER_TOKEN \
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ def many_vars():
z0 = z1 = z2 = z3 = z4 = z5 = z6 = z7 = z8 = z9 = 42
while z9 > 0:
z9 = z9 - 1
+z9
"""), ns, ns)
many_vars = ns["many_vars"]

Expand Down
Loading
Loading