gh-122937: Add docs about annotations evaluation order #123060
+33
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| 1. Value ``'miss-islington'`` will be assigned | ||
| to name ``username`` in ``User`` class scope | ||
| 2. Name ``str`` is evaluated in the annotated assignment statement |
There was a problem hiding this comment.
This is incorrect in Python 3.14.
There was a problem hiding this comment.
Oh, yes, right! I guess we need two sections: one for 3.14+ and one for older versions.
How would you best describe the current approach? With a PEP link maybe?
terryjreedy
reviewed
Aug 16, 2024
There was a problem hiding this comment.
I can only say that the proposed text looks fine, subject to it being true. Given Jelle's comment, we need separate main and branch patches, separately reviewed (or apply this and followup with a main-only patch). I believe the main patch should have a Changed note.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--123060.org.readthedocs.build/