[3.13] gh-123083: Fix a potential use-after-free in ``STORE_ATTR_WITH… #123235
+31
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…R_WITH_HINT`` (pythongh-123092) (cherry picked from commit 297f2e0) Co-authored-by: Donghee Na <donghee.na@python.org>
This was referenced Aug 22, 2024
corona10
commented
Aug 22, 2024
| /* Ensure dict is GC tracked if it needs to be */ | ||
| if (!_PyObject_GC_IS_TRACKED(dict) && _PyObject_GC_MAY_BE_TRACKED(value)) { | ||
| _PyObject_GC_TRACK(dict); | ||
| } | ||
| /* PEP 509 */ | ||
| dict->ma_version_tag = new_version; | ||
| dict->ma_version_tag = new_version; // PEP 509 |
There was a problem hiding this comment.
@colesbury
Since the structure is a little different from the main branch, I just reordered several codes to match as similar as possible.
colesbury
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_HINT`` (gh-123092)
(cherry picked from commit 297f2e0)
STORE_ATTR_WITH_HINThas potential use-after-free #123083