Skip to content

gh-123401: Fix http.cookies module to support obsolete RFC 850 date format #123405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 11, 2024
Merged

gh-123401: Fix http.cookies module to support obsolete RFC 850 date format #123405

merged 10 commits into from
Dec 11, 2024

Conversation

Konano
Copy link
Contributor

@Konano Konano commented Aug 27, 2024 •
edited
Loading

@ghost
Copy link

ghost commented Aug 27, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Aug 27, 2024
Closed
@bedevere-app
Copy link

bedevere-app bot commented Aug 27, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Wulian233
Wulian233 reviewed Aug 28, 2024
View reviewed changes
@Konano @Wulian233
style(http/cookies): correct typo in regex comment
a373718 
Fix a minor typo in the regex comment by adding a hyphen to "double-quoted" for consistency and clarity. No functional changes to the code logic.

Co-authored-by: Wulian <1055917385@qq.com>
@Konano
Copy link
Contributor Author

Konano commented Sep 5, 2024

@zware Could you please take a look at this PR when you are free? Thanks!

Konano and others added 2 commits September 6, 2024 01:32
@Konano @picnixz
Update Misc/NEWS.d/next/Library/2024-08-27-18-58-01.gh-issue-123401.t…
5cf347d 
…4-FpI.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@Konano
Include two examples from RFC 850
592da51
picnixz
picnixz reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance it seems correct. I'm a bit tired for more in-depth review (and even if I were to approve it, a core dev is needed for merging it) so I'll leave it at it for today.

@Konano
Copy link
Contributor Author

Konano commented Sep 12, 2024

Is anyone available to follow up on this PR? Thanks!

Actually, I'm not sure who to contact...

@Wulian233
Copy link
Contributor

You can request for review on https://discuss.python.org/c/core-dev/23 🙂

vstinner
vstinner approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the tests.

@vstinner
Copy link
Member

I couldn't merge the PR since some mandatory CI jobs didn't run. I clicked on [Update branch]. Let's see if it does unblock the issue.

@vstinner vstinner enabled auto-merge (squash) December 11, 2024 13:06
@vstinner vstinner merged commit 359389e into python:main Dec 11, 2024
38 checks passed
@vstinner
Copy link
Member

Merged, thanks @Konano.

@Konano
Copy link
Contributor Author

Konano commented Dec 11, 2024

Does this PR need to be backported to other versions? @vstinner

@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Dec 11, 2024
@miss-islington-app
Copy link

Thanks @Konano for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2024
@Konano @Wulian233
@picnixz @vstinner @miss-islington
pythongh-123401: Fix http.cookies module to support obsolete RFC 850 …
de4f22b 
…date format (pythonGH-123405)

(cherry picked from commit 359389e)

Co-authored-by: Nano <nanoapezlk@gmail.com>
Co-authored-by: Wulian <1055917385@qq.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Dec 11, 2024

GH-127828 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 11, 2024
@vstinner vstinner added the needs backport to 3.12 only security fixes label Dec 11, 2024
@miss-islington-app
Copy link

Thanks @Konano for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2024
@Konano @Wulian233
@picnixz @vstinner @miss-islington
pythongh-123401: Fix http.cookies module to support obsolete RFC 850 …
347c44b 
…date format (pythonGH-123405)

(cherry picked from commit 359389e)

Co-authored-by: Nano <nanoapezlk@gmail.com>
Co-authored-by: Wulian <1055917385@qq.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Dec 11, 2024

GH-127829 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 11, 2024
@vstinner
Copy link
Member

Does this PR need to be backported to other versions? @vstinner

I created backports to 3.12 and 3.13 branches.

vstinner added a commit that referenced this pull request Dec 11, 2024
@miss-islington @Konano
@Wulian233 @picnixz @vstinner
[3.12] gh-123401: Fix http.cookies module to support obsolete RFC 850…
b0615a8 
… date format (GH-123405) (#127829)

gh-123401: Fix http.cookies module to support obsolete RFC 850 date format (GH-123405)
(cherry picked from commit 359389e)

Co-authored-by: Nano <nanoapezlk@gmail.com>
Co-authored-by: Wulian <1055917385@qq.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Dec 11, 2024
@miss-islington @Konano
@Wulian233 @picnixz @vstinner
[3.13] gh-123401: Fix http.cookies module to support obsolete RFC 850…
a94e20e 
… date format (GH-123405) (#127828)

gh-123401: Fix http.cookies module to support obsolete RFC 850 date format (GH-123405)
(cherry picked from commit 359389e)

Co-authored-by: Nano <nanoapezlk@gmail.com>
Co-authored-by: Wulian <1055917385@qq.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@Konano
Copy link
Contributor Author

Konano commented Dec 11, 2024

It seems everything is OK 🎉

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@Konano @Wulian233
@picnixz @vstinner @srinivasreddy
pythongh-123401: Fix http.cookies module to support obsolete RFC 850 …
5258f0e 
…date format (python#123405)

Co-authored-by: Wulian <1055917385@qq.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@Wulian233 Wulian233 Wulian233 left review comments

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Konano @Wulian233 @vstinner @picnixz