Skip to content

[3.13] Fix typos in docs and what's new #123451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 2, 2024
Merged

[3.13] Fix typos in docs and what's new #123451

merged 7 commits into from
Sep 2, 2024

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Aug 29, 2024 •
edited
Loading

cherry pick #123336

Because conflict #123336 (comment)

I'm not going to create a PR for 3.12
#123336 (comment) @hugovk

📚 Documentation preview 📚: https://cpython-previews--123451.org.readthedocs.build/

AlexWaygood
AlexWaygood reviewed Aug 29, 2024
View reviewed changes
AlexWaygood
AlexWaygood previously requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backport PR seems to be making changes the original PR didn't make, which are incorrect and are causing test failures

@bedevere-app
Copy link

bedevere-app bot commented Aug 29, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Wulian233
Copy link
Contributor Author

Wulian233 commented Aug 29, 2024 •
edited
Loading

Also contain #123201

Fixed

@encukou
Copy link
Member

encukou commented Aug 29, 2024

As a reminder, 3.13 is in RC phase; code changes need a very good reason to be included.

Could you limit this to the documentation?

@Wulian233
Copy link
Contributor Author

These are just comments in the code, not real changes. But if necessary, I can limit docs and what's new parts, total 4 files :)

@AlexWaygood AlexWaygood dismissed their stale review August 29, 2024 09:31

there's no longer a NameError

@Wulian233 Wulian233 changed the title [3.13] Fix typos in docs, error messages and comments [3.13] Fix typos in docs and what's new Aug 29, 2024
@brettcannon brettcannon removed their request for review August 29, 2024 17:50
encukou
encukou reviewed Aug 30, 2024
View reviewed changes
@Yhg1s Yhg1s merged commit 5c408e3 into python:3.13 Sep 2, 2024
27 checks passed
@Wulian233 Wulian233 deleted the patch-313 branch September 2, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

@hugovk hugovk hugovk approved these changes

@AlexWaygood AlexWaygood AlexWaygood left review comments

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@gpshead gpshead Awaiting requested review from gpshead

@tiran tiran Awaiting requested review from tiran

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

@willingc willingc Awaiting requested review from willingc

Assignees

@encukou encukou

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Wulian233 @encukou @hugovk @AlexWaygood @Yhg1s @picnixz