Add shims for iOS C++ compilation #123620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ned-deily
approved these changes
Sep 3, 2024
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 4, 2024
Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
|
GH-123656 is a backport of this pull request to the 3.13 branch. |
freakboy3742
added a commit
that referenced
this pull request
Sep 4, 2024
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 6, 2024
…3656) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 6, 2024
…3656) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 6, 2024
…3656) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 6, 2024
) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
…3656) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
…3656) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
…3656) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Oct 9, 2024
…3656) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…3656) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…3656) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…3656) Add shims for iOS C++ compilation (pythonGH-123620) Add shims for iOS C++ compilation. (cherry picked from commit 135dad9) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iOS directory contains shims that can be used as a proxy for invoking the iOS compilers. These shims are required because tools often assume that the first word on a command line is the compiler; but iOS compiler invocation requires multiple words. Setting
CC="xcrun --sdk iphoneos -target arm64-apple-ios"can cause problems with some build tooling (including, but not limited to distutils).This PR adds shims for the C++ compiler. It is technically possible to use
clangas a C++ compiler; however, invokingclang++implies the-lstdc++argument, and most C++ build systems don't explicitly list-lstdc++as a required argument.CPython itself doesn't use these shims itself for compilation, but
CXXis captured as part ofsysconfig, and is that configuration is used extensively by packages in the third-party packaging ecosystem. Providing these shims is an entirely a convenience for compiling those packages.