Skip to content

gh-123811: test that round() can return signed zero #123829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2024
Merged

gh-123811: test that round() can return signed zero #123829

merged 3 commits into from
Sep 11, 2024

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Sep 8, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 8, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 8, 2024
Closed
@skirpichev

This comment was marked as resolved.

Sign in to view
vstinner
vstinner approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eclips4 Eclips4 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 10, 2024
@vstinner vstinner merged commit d2b9b6f into python:main Sep 11, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2024
@skirpichev @miss-islington
pythongh-123811: test that round() can return signed zero (pythonGH-1…
c8c640b 
…23829)

(cherry picked from commit d2b9b6f)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 11, 2024

GH-123938 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 11, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2024
@skirpichev @miss-islington
pythongh-123811: test that round() can return signed zero (pythonGH-1…
f0c45be 
…23829)

(cherry picked from commit d2b9b6f)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 11, 2024

GH-123939 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 11, 2024
@vstinner
Copy link
Member

Merged, thanks @skirpichev.

@skirpichev skirpichev deleted the test-round-szero-123811 branch September 11, 2024 09:29
vstinner added a commit that referenced this pull request Sep 11, 2024
@miss-islington @skirpichev @vstinner
[3.12] gh-123811: test that round() can return signed zero (GH-123829) (
8ca75ee 
#123939)

gh-123811: test that round() can return signed zero (GH-123829)
(cherry picked from commit d2b9b6f)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchaka
Copy link
Member

Is this tested for Decimal?

Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
@miss-islington @skirpichev
[3.13] gh-123811: test that round() can return signed zero (GH-123829) (
243db20 
#123938)

gh-123811: test that round() can return signed zero (GH-123829)
(cherry picked from commit d2b9b6f)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skirpichev @vstinner @serhiy-storchaka @Eclips4 @picnixz