Skip to content

gh-123290: curses: fix reference leaks in error-branches and cleanup module's initialization #123910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

gh-123290: curses: fix reference leaks in error-branches and cleanup module's initialization #123910

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3ce06f4
Fix reference leaks in the error-branches.
picnixz Aug 24, 2024
81bcde8
protect macros expansions using `do { ... } while (0)` constructions
picnixz Sep 10, 2024
848cc3e
use uppercase global flags
picnixz Sep 10, 2024
ea3fd8d
cosmetic changes
picnixz Sep 10, 2024
557a53c
improve `SetDictInt` macro
picnixz Sep 10, 2024
a92fc1f
undef utililty macros
picnixz Sep 10, 2024
9ce0289
improve macro usage
picnixz Sep 10, 2024
fd7372a
update globals
picnixz Sep 10, 2024
384716d
address Victor's review
picnixz Sep 11, 2024
24f47a1
fix compilation if `Py_GIL_DISABLED` is defined
picnixz Sep 11, 2024
4a1003c
use a local macro
picnixz Sep 11, 2024
356b00c
remove unused undefs
picnixz Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cosmetic changes
  • Loading branch information
@picnixz
picnixz committed Sep 10, 2024
commit ea3fd8da7a8b6066b7f9e2289c74d95c19e6923c
4 changes: 1 addition & 3 deletions Modules/_cursesmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3309,14 +3309,12 @@ static PyObject *
_curses_initscr_impl(PyObject *module)
/*[clinic end generated code: output=619fb68443810b7b input=514f4bce1821f6b5]*/
{
WINDOW *win;

if (CURSES_INITSCR_CALLED) {
wrefresh(stdscr);
return (PyObject *)PyCursesWindow_New(stdscr, NULL);
}

win = initscr();
WINDOW *win = initscr();

if (win == NULL) {
PyErr_SetString(PyCursesError, catchall_NULL);
Expand Down