Skip to content

GH-123996: Explicitly mark 'self_or_null' as an array of size 1 to ensure that it is kept in memory for calls #124003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2024
Merged

GH-123996: Explicitly mark 'self_or_null' as an array of size 1 to ensure that it is kept in memory for calls #124003

merged 4 commits into from
Sep 12, 2024
+344 −327

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Sep 12, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 12, 2024
Closed
@iritkatriel
Copy link
Member

There are tests for the generator, should this be covered there?

@markshannon
Copy link
Member Author

There are tests for the generator, should this be covered there?

I've added a couple of tests

@markshannon
Copy link
Member Author

Test failures are the usual oddities of the emulated platforms

@markshannon markshannon merged commit 4ed7d1d into python:main Sep 12, 2024
61 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markshannon @iritkatriel