Skip to content

gh-124044: protect macros expansions in _cursesmodule.c using do { ... } while (0) constructions #124045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Sep 13, 2024

A little PR for this specific step. It can probably be merged whenever it is needed. I think I'll leave the global variables alone, or I'll rename them in yet another PR if you want Victor.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner enabled auto-merge (squash) September 13, 2024 11:07
@picnixz picnixz changed the title gh-124044: protect macros expansions in _cursesmodules.c using do { ... } while (0) constructions gh-124044: protect macros expansions in _cursesmodule.c using do { ... } while (0) constructions Sep 13, 2024
@vstinner vstinner merged commit e49d1b4 into python:main Sep 13, 2024
39 checks passed
@picnixz picnixz deleted the curses/do-while-macros-124044 branch September 13, 2024 11:29
@picnixz
Copy link
Member Author

picnixz commented Sep 13, 2024

Sorry for the typo in the commit message :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants