Skip to content

gh-124102: Update internal documentation under PCbuild, so it now correctly states that Windows Dependency Information #124103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 23, 2024
Merged

gh-124102: Update internal documentation under PCbuild, so it now correctly states that Windows Dependency Information #124103

merged 6 commits into from
Sep 23, 2024

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Sep 15, 2024 •
edited
Loading

In https://docs.python.org/3.14/using/configure.html.
Visual Studio 2017 or later is required, actually currently VS2015 is the minimum version.

VS2015 was EOL in 2020 October

https://learn.microsoft.com/lifecycle/products/visual-studio-2015

So I removed VS2015 and earlier version support

Before this change, the description in python.props stated:
https://github.com/python/cpython/blob/main/PCbuild/python.props#L8-L10

Use the latest available version of Visual Studio to build. To override
this and build with an earlier version, pass "/p:PlatformToolset=v100"
(for example) when building.

However, v100 corresponds to Visual Studio 2010, and now Visual Studio 2017 or later is required. v100 is no longer available. See https://docs.python.org/3.14/using/configure.html.

Currently, the latest Visual Studio 2022 uses v143. Therefore, I have changed it to the officially supported Visual Studio 2017 (v141). See https://github.com/python/cpython/blob/main/PCbuild/readme.txt#L62.

To correctly build CPython, the minimum Python required version is now 3.10; otherwise, it will download via NuGet online. See https://github.com/python/cpython/blob/main/PCbuild/find_python.bat#L45

However, descriptions in other files are outdated, mentioning versions like 3.6, 2.7, and 3.4. Due to the long time lapse, these descriptions have become inconsistent across files. I have now standardized them

@Wulian233 Wulian233 requested a review from a team as a code owner September 15, 2024 11:16
@bedevere-app bedevere-app bot mentioned this pull request Sep 15, 2024
Closed
@terryjreedy
Copy link
Member

News entry needed. (I would also want it to merge.)

@Wulian233
Copy link
Contributor Author

No problem (Before I thought only changing the readme and syncing information not required NEWS😥)

@Wulian233
news
12017f8
@Wulian233
env.bat now support VS2017+ (2015 is min ver)
6c54282 
NOTE: remove find VS2015 earlier bacause not support
@Wulian233
Copy link
Contributor Author

Wulian233 commented Sep 16, 2024 •
edited
Loading

News entry needed. (I would also want it to merge.)

I have finished NEWS, in addition, I made env.bat support VS2017 and above version detection

zooba
zooba reviewed Sep 16, 2024
View reviewed changes
@Wulian233 Wulian233 changed the title gh-124102: Update Dependency Information for PCBuild to Correct Information gh-124102: Update internal documentation under PCbuild, so it now correctly states that Windows Dependency Information Sep 17, 2024
@Wulian233
Copy link
Contributor Author

Hello @zooba , thank you for your review. I have made the changes, could you please review again? Thank you!

(I think I made some additional changes at the time, do you think these should be changed? I am considering revert the changes made to these two files)

Tools/c-analyzer/distutils/cygwinccompiler.py
Tools/c-analyzer/distutils/_msvccompiler.py

@zooba
Copy link
Member

zooba commented Sep 23, 2024

Yeah, revert the Tools directory changes and we're good to go (we explicitly aren't maintaining distutils anymore, including the copy used for tests, at least until the tests start breaking).

@Wulian233
Copy link
Contributor Author

Yeah, revert the Tools directory changes and we're good to go (we explicitly aren't maintaining distutils anymore, including the copy used for tests, at least until the tests start breaking).

Finished 🚀

@zooba zooba enabled auto-merge (squash) September 23, 2024 22:56
@zooba zooba merged commit 27a62e7 into python:main Sep 23, 2024
36 checks passed
@Wulian233 Wulian233 deleted the build-ver branch September 24, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba left review comments

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wulian233 @terryjreedy @zooba