Skip to content

gh-124309: Fix the AssertionError when using the happy_eyeballs_delay argument in open_connection #124311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+7 −1
Closed

gh-124309: Fix the AssertionError when using the happy_eyeballs_delay argument in open_connection #124311

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7775940
Fix the exception when using the happy_eyeballs_delay parameter in op…
rruuaanng Sep 22, 2024
516b279
Added waiting list to troubleshoot erroneous tasks
rruuaanng Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Lib/asyncio/staggered.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ async def staggered_race(coro_fns, delay, *, loop=None):
winner_index = None
exceptions = []
running_tasks = []
waiting_tasks = []

async def run_one_coro(previous_failed) -> None:
# Wait for the previous task to finish, or for delay seconds
Expand All @@ -78,6 +79,7 @@ async def run_one_coro(previous_failed) -> None:
# cancelled, otherwise there will be a "Task destroyed but it is
# pending" later.
await tasks.wait_for(previous_failed.wait(), delay)
waiting_tasks.append(previous_failed)
# Get the next coroutine to run
try:
this_index, coro_fn = next(enum_coro_fns)
Expand All @@ -87,7 +89,11 @@ async def run_one_coro(previous_failed) -> None:
this_failed = locks.Event()
next_task = loop.create_task(run_one_coro(this_failed))
running_tasks.append(next_task)
assert len(running_tasks) == this_index + 2
running_tasks.append(next_task)
if len(waiting_tasks) != len(running_tasks):
task = running_tasks.pop(len(waiting_tasks) - 1)
if task.cancelled():
task.cancel()
# Prepare place to put this coroutine's exceptions if not won
exceptions.append(None)
assert len(exceptions) == this_index + 1
Expand Down
Loading