Skip to content

gh-123873: sqlite3.threadsafety aligned with python module capabilities #124316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-123873: sqlite3.threadsafety aligned with python module capabilities #124316

wants to merge 3 commits into from
+3 −2

Conversation

rghe
Copy link
Contributor

@rghe rghe commented Sep 22, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 22, 2024
Open
@ZeroIntensity
Copy link
Member

This is a user-facing bug, we need a news entry.

@rghe
Copy link
Contributor Author

rghe commented Sep 23, 2024

News added, thank you.

@ZeroIntensity
Copy link
Member

I've added the sqlite topic label to get some people who are more familiar with the module on this -- the ASan failures have me a little worried.

@rghe @ZeroIntensity
Update Misc/NEWS.d/next/Library/2024-09-23-16-16-06.gh-issue-123873.r…
56a88e0 
…zdy2x.rst

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ZeroIntensity
ZeroIntensity approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I don't know what happened with ASan. LGTM.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Sep 24, 2024 •
edited
Loading

Thanks, but I'd prefer if we fixed the root cause. Landing this in main won't help anybody anyway, and backporting to 3.13 is probably out of the question now that we're so close to the final release. (It would have to be 3.13.1 earliest.)

@rghe
Copy link
Contributor Author

rghe commented Sep 24, 2024

Yes, I understand, but IMHO, even with #118172 fixed, the sqlite module can't share cursors between threads without extensive changes, so returning 3 is still a bug.
Fixing #118172 should allow connection sharing, however, so perhaps a better fix would be returning 2 ?
BTW, I'd like to help, if you think it could be useful.

@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees
No one assigned
Labels
awaiting core review DO-NOT-MERGE topic-sqlite3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rghe @ZeroIntensity @erlend-aasland