Skip to content

gh-58956: Set f_trace on frames with breakpoints after setting a new breakpoint #124454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2024
Merged

gh-58956: Set f_trace on frames with breakpoints after setting a new breakpoint #124454

merged 5 commits into from
Oct 15, 2024
+39 −0

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Sep 24, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 24, 2024
Closed
iritkatriel
iritkatriel reviewed Sep 30, 2024
View reviewed changes
Misc/NEWS.d/next/Library/2024-09-24-18-16-59.gh-issue-58956.0wFrBR.rst Outdated
@@ -0,0 +1 @@
Setting a :mod:`pdb` breakpoint on a function that's already in the call stack will enable the trace function on that frame so the breakpoint would trigger.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be reworded to make it clearer what the change is (e.g., "Fix bug where..."). They way it's written it's not immediately clear what the old vs new behaviour is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ^

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, missed that. Do you think the current news is better?

iritkatriel
iritkatriel reviewed Sep 30, 2024
View reviewed changes
@gaogaotiantian @iritkatriel
Update Misc/NEWS.d/next/Library/2024-09-24-18-16-59.gh-issue-58956.0w…
0cb7fe7 
…FrBR.rst

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@gaogaotiantian gaogaotiantian added 3.12 only security fixes 3.13 bugs and security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes and removed 3.12 only security fixes 3.13 bugs and security fixes labels Oct 15, 2024
@gaogaotiantian gaogaotiantian merged commit 12eaadc into python:main Oct 15, 2024
43 checks passed
@miss-islington-app
Copy link

Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@gaogaotiantian gaogaotiantian deleted the fix-module-breakpoint branch October 15, 2024 19:56
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2024
@gaogaotiantian @miss-islington
pythongh-58956: Set f_trace on frames with breakpoints after setting …
1c58548 
…a new breakpoint (pythonGH-124454)

(cherry picked from commit 12eaadc)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2024
@gaogaotiantian @miss-islington
pythongh-58956: Set f_trace on frames with breakpoints after setting …
e696ca7 
…a new breakpoint (pythonGH-124454)

(cherry picked from commit 12eaadc)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 15, 2024

GH-125548 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 15, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 15, 2024

GH-125549 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 15, 2024
gaogaotiantian added a commit that referenced this pull request Oct 15, 2024
@miss-islington @gaogaotiantian
[3.13] gh-58956: Set f_trace on frames with breakpoints after setting…
2ded598 
… a new breakpoint (GH-124454) (#125548)

gh-58956: Set f_trace on frames with breakpoints after setting a new breakpoint (GH-124454)
(cherry picked from commit 12eaadc)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@gaogaotiantian @ebonnal
pythongh-58956: Set f_trace on frames with breakpoints after setting …
edc7c8d 
…a new breakpoint (python#124454)
gaogaotiantian added a commit to miss-islington/cpython that referenced this pull request Jan 17, 2025
@gaogaotiantian
pythongh-58956: Set f_trace on frames with breakpoints after setting …
acfd3d5 
…a new breakpoint (pythonGH-124454)

(cherry picked from commit 12eaadc)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
gaogaotiantian added a commit that referenced this pull request Jan 25, 2025
@miss-islington @gaogaotiantian
[3.12] gh-58956: Set f_trace on frames with breakpoints after setting…
c17d30b 
… a new breakpoint (GH-124454) (#125549)

* gh-58956: Set f_trace on frames with breakpoints after setting a new breakpoint (GH-124454)
(cherry picked from commit 12eaadc)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaogaotiantian @iritkatriel