Skip to content

gh-124842: Fix test.support.import_helper.make_legacy_pyc() #124843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2024
Merged

gh-124842: Fix test.support.import_helper.make_legacy_pyc() #124843

merged 1 commit into from
Oct 1, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 1, 2024 •
edited by bedevere-app bot
Loading

For source file "path/to/file.py" it created file with incorrect path "/absolute/path/to/path/to/file.pyc" instead of "path/to/file.pyc".

@serhiy-storchaka
pythongh-124842: Fix test.support.import_helper.make_legacy_pyc()
690ba64 
For source file "path/to/file.py" it created file with incorrect path
"/absolute/path/to/path/to/file.pyc" instead of "path/to/file.pyc".
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 1, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 1, 2024
Closed
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) October 1, 2024 16:04
@serhiy-storchaka serhiy-storchaka merged commit 60ff67d into python:main Oct 1, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the import_helper-make_legacy_pyc branch October 1, 2024 16:05
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2024
@serhiy-storchaka @miss-islington
pythongh-124842: Fix test.support.import_helper.make_legacy_pyc() (py…
ec68d46 
…thonGH-124843)

For source file "path/to/file.py" it created file with incorrect path
"/absolute/path/to/path/to/file.pyc" instead of "path/to/file.pyc".
(cherry picked from commit 60ff67d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2024
@serhiy-storchaka @miss-islington
pythongh-124842: Fix test.support.import_helper.make_legacy_pyc() (py…
3489087 
…thonGH-124843)

For source file "path/to/file.py" it created file with incorrect path
"/absolute/path/to/path/to/file.pyc" instead of "path/to/file.pyc".
(cherry picked from commit 60ff67d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 1, 2024

GH-124853 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 1, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 1, 2024

GH-124854 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 1, 2024
serhiy-storchaka added a commit that referenced this pull request Oct 1, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-124842: Fix test.support.import_helper.make_legacy_pyc() (G…
79746b3 
…H-124843) (GH-124854)

For source file "path/to/file.py" it created file with incorrect path
"/absolute/path/to/path/to/file.pyc" instead of "path/to/file.pyc".
(cherry picked from commit 60ff67d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Revert "pythongh-124842: Fix test.support.import_helper.make_legacy_p…
a117765 
…yc() (pythonGH-124843)"

This reverts commit 60ff67d.
serhiy-storchaka added a commit that referenced this pull request Oct 7, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-124842: Fix test.support.import_helper.make_legacy_pyc() (G…
970f3b7 
…H-124843) (GH-124853)

For source file "path/to/file.py" it created file with incorrect path
"/absolute/path/to/path/to/file.pyc" instead of "path/to/file.pyc".
(cherry picked from commit 60ff67d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@serhiy-storchaka