Code

gh-124984: Fix ssl thread safety#124993

Code

Merged

vstinner merged 60 commits intopython:mainpython/cpython:mainfrom

ZeroIntensity:fix-ssl-threadsafetyZeroIntensity/cpython:fix-ssl-threadsafetyCopy head branch name to clipboard

Oct 19, 2024

Commits

Commits on Oct 5, 2024

• Make SSL objects thread safe.

  ZeroIntensity

  committed
  132a2dd

  Copy full SHA for 132a2dd

• Fix silly syntax errors.

  ZeroIntensity

  committed
  572e48f

  Copy full SHA for 572e48f

• Fix thread safety for set_alpn_protocols

  ZeroIntensity

  committed
  b0cd005

  Copy full SHA for b0cd005

• Fix thread safety for configure_hostname

  ZeroIntensity

  committed
  0629acd

  Copy full SHA for 0629acd

• Make some more operations atomic.

  ZeroIntensity

  committed
  3712d05

  Copy full SHA for 3712d05

• Fix thread safety with hostnames.

  ZeroIntensity

  committed
  eb06e05

  Copy full SHA for eb06e05

• Fix thread safety for BIO.

  ZeroIntensity

  committed
  30fce36

  Copy full SHA for 30fce36

• Add blurb.

  ZeroIntensity

  committed
  0d63bfb

  Copy full SHA for 0d63bfb

• Add test.

  ZeroIntensity

  committed
  7268ebb

  Copy full SHA for 7268ebb

• Fix deadlock.

  ZeroIntensity

  committed
  28004f1

  Copy full SHA for 28004f1

• Remove useless locks in constructor.

  ZeroIntensity

  committed
  caa205a

  Copy full SHA for caa205a

• Zero-out locks upon initialization.

  ZeroIntensity

  committed
  578d40a

  Copy full SHA for 578d40a

• Wrap lock initializations with #ifdef Py_GIL_DISABLED

  ZeroIntensity

  committed
  c601906

  Copy full SHA for c601906

• Fix lock ordering deadlock.

  ZeroIntensity

  committed
  014a95a

  Copy full SHA for 014a95a

• Remove lock for do_handshake()

  ZeroIntensity

  committed
  ebb8b40

  Copy full SHA for ebb8b40

• Fix typo.

  ZeroIntensity

  committed
  a3ff154

  Copy full SHA for a3ff154

• Make tests better.

  ZeroIntensity

  committed
  591535f

  Copy full SHA for 591535f

• Fix tests.

  ZeroIntensity

  committed
  53e6d59

  Copy full SHA for 53e6d59

• Fix missing global.

  ZeroIntensity

  committed
  cd047ba

  Copy full SHA for cd047ba

• Update comment.

  ZeroIntensity

  committed
  3f3715b

  Copy full SHA for 3f3715b

• Update Modules/_ssl.c

  Show description for d808932
  

  ZeroIntensity

  and

  picnixz

  authored
  d808932

  Copy full SHA for d808932

• Update Modules/_ssl.c

  Show description for df26ffe
  

  ZeroIntensity

  and

  picnixz

  authored
  df26ffe

  Copy full SHA for df26ffe

• Merge branch 'fix-ssl-threadsafety' of https://github.com/ZeroIntensity/cpython into fix-ssl-threadsafety

  ZeroIntensity

  committed
  288c9a3

  Copy full SHA for 288c9a3

• Don't lock Py* functions.

  ZeroIntensity

  committed
  c8df918

  Copy full SHA for c8df918

• Clarify comment.

  ZeroIntensity

  committed
  23aa4f9

  Copy full SHA for 23aa4f9

• Remove useless functions in threaded tests and lower number of threads.

  ZeroIntensity

  committed
  92d9525

  Copy full SHA for 92d9525

• Remove more useless functions.

  ZeroIntensity

  committed
  eff01db

  Copy full SHA for eff01db

• Add note about thread count

  ZeroIntensity

  authored
  f678df1

  Copy full SHA for f678df1

Commits on Oct 7, 2024

• Clarify news entry.

  ZeroIntensity

  committed
  e96bf31

  Copy full SHA for e96bf31

• Remove lock for deallocator.

  ZeroIntensity

  committed
  028bb6a

  Copy full SHA for 028bb6a

Commits on Oct 10, 2024

• Remove PySSL_LOCK() and PySSL_UNLOCK()

  ZeroIntensity

  committed
  f578c8e

  Copy full SHA for f578c8e

• Use argument clinic for critical sections.

  ZeroIntensity

  committed
  80aea32

  Copy full SHA for 80aea32

• Switch reused_session to clinic

  ZeroIntensity

  committed
  7d76621

  Copy full SHA for 7d76621

• Switch session to argument clinic.

  ZeroIntensity

  committed
  44a8c48

  Copy full SHA for 44a8c48

• Switch owner to argument clinic.

  ZeroIntensity

  committed
  6e13fed

  Copy full SHA for 6e13fed

• Switch server_hostname to argument clinic.

  ZeroIntensity

  committed
  2424f67

  Copy full SHA for 2424f67

• Switch context to argument clinic.

  ZeroIntensity

  committed
  9b91bc0

  Copy full SHA for 9b91bc0

• Switch check_hostname to argument clinic.

  ZeroIntensity

  committed
  c0377eb

  Copy full SHA for c0377eb

• Switch host_flags to argument clinic.

  ZeroIntensity

  committed
  be02857

  Copy full SHA for be02857

• Switch minimum_version to argument clinic.

  ZeroIntensity

  committed
  fe362d4

  Copy full SHA for fe362d4

• Switch maximum_version to argument clinic.

  ZeroIntensity

  committed
  fe088d6

  Copy full SHA for fe088d6

• Switch sni_callback to argument clinic.

  ZeroIntensity

  committed
  f9ae852

  Copy full SHA for f9ae852

• Switch num_tickets to clinic.

  ZeroIntensity

  committed
  eb61a84

  Copy full SHA for eb61a84

• Switch options to argument clinic.

  ZeroIntensity

  committed
  b9c2732

  Copy full SHA for b9c2732

• Switch protocol to argument clinic.

  ZeroIntensity

  committed
  ae25f65

  Copy full SHA for ae25f65

• Switch verify_flags to argument clinic.

  ZeroIntensity

  committed
  4950f45

  Copy full SHA for 4950f45

• Switch verify_mode to argument clinic.

  ZeroIntensity

  committed
  fee2d4f

  Copy full SHA for fee2d4f

• Switch security_level to argument clinic.

  ZeroIntensity

  committed
  6449c95

  Copy full SHA for 6449c95

• Switch MemoryBIO to argument clinic.

  ZeroIntensity

  committed
  a0fc838

  Copy full SHA for a0fc838

• Switch has_ticket to argument clinic.

  ZeroIntensity

  committed
  8c4e20d

  Copy full SHA for 8c4e20d

• Switch session_id to argument clinic.

  ZeroIntensity

  committed
  44f1782

  Copy full SHA for 44f1782

• Switch ticket_lifetime_hint to argument clinic.

  ZeroIntensity

  committed
  216c318

  Copy full SHA for 216c318

• Switch time to argument clinic.

  ZeroIntensity

  committed
  701bf00

  Copy full SHA for 701bf00

• Switch timeout to argument clinic.

  ZeroIntensity

  committed
  ffc4879

  Copy full SHA for ffc4879

• Fix name inconsistency.

  ZeroIntensity

  committed
  ebd621b

  Copy full SHA for ebd621b

• Fix build complaints.

  ZeroIntensity

  committed
  3b81e78

  Copy full SHA for 3b81e78

• Fix more build complaints.

  ZeroIntensity

  committed
  e7e0f47

  Copy full SHA for e7e0f47

Commits on Oct 11, 2024

• Fix failing builds.

  ZeroIntensity

  committed
  8cf4992

  Copy full SHA for 8cf4992

Commits on Oct 18, 2024

• Clarify comment and use catch_threading_exception()

  ZeroIntensity

  committed
  d9152af

  Copy full SHA for d9152af

Commits on Oct 19, 2024

• Check for SkipTest in exc_value.

  ZeroIntensity

  committed
  07f848c

  Copy full SHA for 07f848c