gh-123961: make curses global flags free-threaded friendly
#125000
Conversation
ee22931 to
5a119c7
Compare
…-threading-friendly-123961
If you cannot have two instances of the |
From what I understand, it'd be possible to access the curses extension state from different threads (not necessarily processes). Or am I wrong? Ok I know why I didn't get the error in the terminal; it's because the module is still single-phase for now. Once it's multi-phase, I'll also get an error if I want to load it more than once per process (namely, I won't need to use the |
|
I suggest to first make the _curses extension use the multiphase init API, and then look on how to make it safe to be used on a Free Threaded build. |
|
Hmm, multiphase init shouldn't affect this. IIUC, module states need to be locked for free-threaded extensions. |
| static int | ||
| cursesmodule_exec(PyObject *module) | ||
| { | ||
| if (_Py_atomic_load_int(&curses_module_loaded)) { |
There was a problem hiding this comment.
The atomics here don't really do anything useful because you are not atomically checking and setting the variable together. Either use an atomic compare-exchange or don't use atomics at all.
Within an interpreter, the import lock will prevent multiple concurrent executions of cursesmodule_exec, but I'm not sure about what happens with multiple interpreters.
There was a problem hiding this comment.
FWIW, curses doesn't support subinterpreters, as indicated by the m_size being -1
There was a problem hiding this comment.
Within an interpreter, the import lock will prevent multiple concurrent executions of cursesmodule_exec
Oh ok. Thanks for the tip. I wasn't really sure on this one. I'll revert this change later
AFAIK, no (at least I'm clearly not an expert in free-threading nor in concurrency in general, so I really appreciate your help! |
I think it's worth figuring out what sort of locking and thread-safety strategy we should use for |
|
I think I'll close this PR for now. We'll likely need to revisit this question in a separate issue and PRs. |
We allow global variables indicating whether the underlying curses functions have been called to be safely used in free-threaded builds.
In addition, since
cursesmanages the screen, only onecursesmodule can be loaded per process (i.e the exec() function is executed only once and anImportErroris raised if the user attempts to load multiplecursesmodules within the same process).This can be tested via:
./python -c "import sys; import subprocess; subprocess.run(['./Programs/_testembed', 'test_repeated_init_exec', 'import curses'])"_cursesmodule.cto fix reference leaks #123961