Skip to content

gh-125543: Add an internal C API for dynamic arrays #125554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 22 commits into from
Closed

gh-125543: Add an internal C API for dynamic arrays #125554

wants to merge 22 commits into from

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Oct 15, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 15, 2024
Closed
@ZeroIntensity ZeroIntensity requested a review from Eclips4 October 15, 2024 21:40
Eclips4
Eclips4 reviewed Oct 15, 2024
View reviewed changes
@ZeroIntensity ZeroIntensity marked this pull request as ready for review October 19, 2024 16:33
@ZeroIntensity ZeroIntensity requested review from a team and erlend-aasland as code owners October 19, 2024 16:33
Eclips4
Eclips4 reviewed Oct 19, 2024
View reviewed changes
Eclips4
Eclips4 approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation and API look good to me. Let's see what others think.

@Eclips4 Eclips4 requested a review from vstinner October 19, 2024 21:17
vstinner
vstinner requested changes Oct 19, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I'm not convinced that there is a need for such API. I suggest to discuss it on the issue.

@bedevere-app
Copy link

bedevere-app bot commented Oct 19, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner requested changes

@Eclips4 Eclips4 Eclips4 approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees
No one assigned
Labels
awaiting changes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeroIntensity @vstinner @Eclips4