Skip to content

gh-125679: multiprocessing Lock and RLock - fix invalid representation string on MacOSX. #125680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2024
Merged

gh-125679: multiprocessing Lock and RLock - fix invalid representation string on MacOSX. #125680

merged 3 commits into from
Nov 7, 2024

Conversation

YvesDup
Copy link
Contributor

@YvesDup YvesDup commented Oct 18, 2024 •
edited
Loading

The __repr__ method of Lockand RLock classes are modified.
As described in the isssue, self._semlock._get_value() == 1 is replaced with a call to _is_zero() method.

I've added 2 unit tests test_repr_lock and test_repr_rlock in _TestLock class in _test_multiprocessing.py file.

@YvesDup YvesDup requested a review from gpshead as a code owner October 18, 2024 06:26
@bedevere-app bedevere-app bot mentioned this pull request Oct 18, 2024
Closed
@gpshead gpshead self-assigned this Oct 18, 2024
@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 22, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit d6bb529 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 22, 2024
@gpshead gpshead enabled auto-merge (squash) October 29, 2024 06:05
@gpshead gpshead added the needs backport to 3.13 bugs and security fixes label Oct 29, 2024
@YvesDup
Copy link
Contributor Author

YvesDup commented Nov 4, 2024

@gpshead thank you for your agrement

@gpshead gpshead added the needs backport to 3.12 only security fixes label Nov 7, 2024
@gpshead gpshead merged commit 75f7cf9 into python:main Nov 7, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @YvesDup for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2024
@YvesDup @miss-islington
pythongh-125679: multiprocessing Lock and RLock - fix invalid represe…
394b72e 
…ntation string on MacOSX. (pythonGH-125680)

(cherry picked from commit 75f7cf9)

Co-authored-by: Duprat <yduprat@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 7, 2024

GH-126533 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 7, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2024
@YvesDup @miss-islington
pythongh-125679: multiprocessing Lock and RLock - fix invalid represe…
7280bca 
…ntation string on MacOSX. (pythonGH-125680)

(cherry picked from commit 75f7cf9)

Co-authored-by: Duprat <yduprat@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 7, 2024

GH-126534 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 7, 2024
gpshead pushed a commit that referenced this pull request Nov 7, 2024
@miss-islington @YvesDup
[3.13] gh-125679: multiprocessing Lock and RLock - fix invalid repres…
3b05ef1 
…entation string on MacOSX. (GH-125680) (#126533)

gh-125679: multiprocessing Lock and RLock - fix invalid representation string on MacOSX. (GH-125680)
(cherry picked from commit 75f7cf9)

Co-authored-by: Duprat <yduprat@gmail.com>
gpshead pushed a commit that referenced this pull request Nov 7, 2024
@miss-islington @YvesDup
[3.12] gh-125679: multiprocessing Lock and RLock - fix invalid repres…
4f10b8e 
…entation string on MacOSX. (GH-125680) (#126534)

gh-125679: multiprocessing Lock and RLock - fix invalid representation string on MacOSX. (GH-125680)
(cherry picked from commit 75f7cf9)

Co-authored-by: Duprat <yduprat@gmail.com>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@YvesDup @picnixz
pythongh-125679: multiprocessing Lock and RLock - fix invalid represe…
6e05822 
…ntation string on MacOSX. (python#125680)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@YvesDup @ebonnal
pythongh-125679: multiprocessing Lock and RLock - fix invalid represe…
2d4d268 
…ntation string on MacOSX. (python#125680)
@YvesDup YvesDup deleted the lock-macosx-multiprocessing branch May 22, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@gpshead gpshead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YvesDup @bedevere-bot @gpshead