Skip to content

bpo-31341: cleanup IRIX-specific macros sgi and __sgi #12587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bpo-31341: cleanup IRIX-specific macros sgi and __sgi #12587

wants to merge 1 commit into from

Conversation

yan12125
Copy link
Contributor

@yan12125 yan12125 commented Mar 27, 2019 •
edited by bedevere-bot
Loading

To make work on curses-related modules simpler https://bugs.python.org/issue28190

https://bugs.python.org/issue31341

benjaminp
benjaminp requested changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@benjaminp benjaminp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good but needs a rebase.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@yan12125
Copy link
Contributor Author

I have made the requested changes; please review again.

As a side note, the merge conflict was due to additions for VxWorks (https://github.com/python/cpython/pull/12118/files#diff-a6f29e907cbb5fffd44d453bcd7b77d5R232).

@bedevere-bot
Copy link

Thanks for making the requested changes!

@benjaminp: please review the changes made to this pull request.

@yan12125 yan12125 changed the title bpo-31341: remove more SGI IRIX-specific codes bpo-31341: cleanup IRIX-specific macros sgi and __sgi Feb 20, 2021
@yan12125
Copy link
Contributor Author

Most IRIX-specific codes are removed in #23023, while there are still references to IRIX-specific macros sgi and __sgi. I rebased this pull request to only remove remaining macros.

@yan12125
Copy link
Contributor Author

Rebased for recent cleanups in Include/Python.h (https://bugs.python.org/issue45434)

@yan12125
Copy link
Contributor Author

Seems no sign of further reviewing, closing.

@yan12125 yan12125 closed this Mar 14, 2022
@yan12125 yan12125 deleted the sgi-irix-cleanup branch March 14, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminp benjaminp Awaiting requested review from benjaminp

Assignees
No one assigned
Labels
awaiting change review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yan12125 @bedevere-bot @benjaminp @the-knights-who-say-ni