gh-125916: Adapt functools.reduce() to Argument Clinic #125999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This coming from #125917. Red alert: to make AC happy, docstring was adjusted. I did some benchmarks. # a.py
import pyperf
from functools import reduce
f = lambda x, y: x + y
lst = list(range(5))
init = 123
runner = pyperf.Runner()
runner.bench_func('reduce(f, lst)', reduce, f, lst)
runner.bench_func('reduce(f, lst, init)', reduce, f, lst, init)Run e.g. with: with results:
So, at least AC-backed argument processing offer some speedup. |
|
Thanks Sergey, I'll review this within today. Ping me tomorrow if I forget. |
PEP 257 says that "Multi-line docstrings consist of a summary line just like a one-line docstring, followed by a blank line, followed by a more elaborate description." This is also a requirement from the Argument Clinic.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
skirpichev
commented
Oct 28, 2024
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland
pushed a commit
that referenced
this pull request
Oct 29, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 29, 2024
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999. (cherry picked from commit 9b14083) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 29, 2024
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999. (cherry picked from commit 9b14083) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
erlend-aasland
pushed a commit
that referenced
this pull request
Oct 29, 2024
erlend-aasland
pushed a commit
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
erlend-aasland
approved these changes
Oct 29, 2024
|
I'll give Jelle and Serhiy a chance to chime in again before landing this. |
|
I plan to land this later today (post noon ET). |
JelleZijlstra
approved these changes
Nov 1, 2024
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
Thanks for the PR, Sergey; thanks for the reviews, Jelle and Serhiy. |
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999.
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Yak-shave in preparation for Argument Clinic adaption in pythongh-125999.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functools.reduces 'initial' to be a keyword argument #125916