Skip to content

gh-126008: Fix the type of return value for ttk.Widget.cget #126102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
+17 −0
Closed

gh-126008: Fix the type of return value for ttk.Widget.cget #126102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c9f7095
fix: `ttk.Widget.cget` has an incorrect return value type
Xiaokang2022 Oct 29, 2024
f6281f8
style
Xiaokang2022 Oct 29, 2024
3cfd9ff
Fixed some bugs
Xiaokang2022 Oct 29, 2024
194c0d5
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 29, 2024
c040d1c
fix lint
Xiaokang2022 Oct 29, 2024
9f0e79a
style
Xiaokang2022 Oct 29, 2024
fb44bef
Merge branch 'main' into fix-ttk-cget
Xiaokang2022 Jan 6, 2025
15cac99
test: Add a simple test for `ttk.Widget.cget`
Xiaokang2022 Jan 6, 2025
aae1a3d
test: Fix tests
Xiaokang2022 Jan 6, 2025
d6303ff
Merge branch 'main' into fix-ttk-cget
Xiaokang2022 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Lib/test/test_ttk/test_widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,11 @@ def test_cb(arg1, **kw):
self.widget.state(['active', '!disabled'])
self.assertEqual(self.widget.state(), ('active', ))

def test_widget_cget(self):
# Check whether the return value of cget is a string
self.assertEqual(self.widget.cget("state"), tkinter.NORMAL)
self.assertEqual(self.widget.cget("text"), "Text")


class AbstractToplevelTest(AbstractWidgetTest, PixelSizeTests):
_rounds_pixels = False
Expand Down
11 changes: 11 additions & 0 deletions Lib/tkinter/ttk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"tclobjs_to_py", "setup_master"]

import tkinter
import _tkinter
from tkinter import _flatten, _join, _stringify, _splitdict


Expand Down Expand Up @@ -572,6 +573,16 @@ def state(self, statespec=None):
return self.tk.splitlist(str(self.tk.call(self._w, "state", statespec)))


def cget(self, key):
"""Return the resource value for a KEY given as string."""
return_value = super().cget(key)
if isinstance(return_value, _tkinter.Tcl_Obj):
return str(return_value)
return return_value

__getitem__ = cget


class Button(Widget):
"""Ttk Button widget, displays a textual label and/or image, and
evaluates a command when pressed."""
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-10-29-03-32-28.gh-issue-126008.wcuSmo.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix an incorrect return value type when getting resource value of ttk widgets.
Loading