Skip to content

gh-126206: make clinic now forcefully regenerates clinic code #126244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2024
Merged

gh-126206: make clinic now forcefully regenerates clinic code #126244

merged 3 commits into from
Nov 1, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Oct 31, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 31, 2024
Closed
corona10
corona10 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

AA-Turner
AA-Turner approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor preference for long options (more readable), but non-blocking.

A

@erlend-aasland @AA-Turner
Address review: use long options for clarity
48f1c82 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews; I agree that using long options is preferred.

@erlend-aasland erlend-aasland enabled auto-merge (squash) November 1, 2024 07:48
@erlend-aasland erlend-aasland merged commit 43447cb into python:main Nov 1, 2024
36 checks passed
@erlend-aasland erlend-aasland deleted the force-clinic-regen branch November 1, 2024 08:17
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@erlend-aasland @picnixz
pythongh-126206: make clinic now forcefully regenerates clinic code (p…
804a666 
…ython#126244)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@erlend-aasland @ebonnal
pythongh-126206: make clinic now forcefully regenerates clinic code (p…
29b074f 
…ython#126244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make regen-all doesn't pass -f to argument clinic
3 participants
@erlend-aasland @corona10 @AA-Turner