Skip to content

gh-126775: make linecache.checkcache threadsafe and GC re-entrency safe #126776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 10, 2024
+9 −5
Merged

gh-126775: make linecache.checkcache threadsafe and GC re-entrency safe #126776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dee2dd7
gh-126775: make linecache.checkcache threadsafe and GC re-entrency safe
graingert Nov 13, 2024
1803401
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 13, 2024
a2399ba
Update Misc/NEWS.d/next/Library/2024-11-13-10-44-25.gh-issue-126775.a…
graingert Nov 19, 2024
61690d5
Merge branch 'main' into make-linecache-clearcache-thread-and-gc-reen…
graingert Nov 19, 2024
535695e
Merge branch 'main' into make-linecache-clearcache-thread-and-gc-reen…
graingert Dec 4, 2024
b98e7ed
Merge branch 'main' into make-linecache-clearcache-thread-and-gc-reen…
graingert Dec 4, 2024
ba0cc8d
Update Lib/linecache.py
graingert Dec 4, 2024
02b605f
Merge branch 'main' into make-linecache-clearcache-thread-and-gc-reen…
graingert Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Lib/linecache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,17 @@ def checkcache(filename=None):
(This is not checked upon each call!)"""

if filename is None:
filenames = list(cache.keys())
elif filename in cache:
filenames = [filename]
# get keys atomically
filenames = cache.copy().keys()
else:
return
filenames = [filename]

for filename in filenames:
entry = cache[filename]
try:
entry = cache[filename]
except KeyError:
continue

if len(entry) == 1:
# lazy cache entry, leave it lazy.
continue
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-11-13-10-44-25.gh-issue-126775.a3ubjh.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make :func:`linecache.checkcache` thread safe and GC re-entrancy safe.
Loading