gh-126061: add PyLong_IsPositive/Negative/Zero/GetSign functions to refcounts.dat
#126788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's enough. |
|
Then I will open this PR to hear more opinions :) cc @vstinner |
refcounts.datrefcounts.dat
skirpichev
requested changes
Nov 14, 2024
vstinner
approved these changes
Nov 14, 2024
refcounts.datrefcounts.dat
skirpichev
approved these changes
Nov 14, 2024
|
Merged, thanks @rruuaanng. |
|
A little help. For CPython :) |
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--126788.org.readthedocs.build/
This PR completes the proposal in #126065, but it only adds GetSign/IsZero/IsPositive/IsNegative
Although it is a draft PR, it is open for review. For other recently added C-API, I need to spend a little time looking for them, if there are no such requirements, it can be merged directly.