Skip to content

bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() #12687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2019
Merged

bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() #12687

merged 2 commits into from
Apr 22, 2019

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Apr 4, 2019 •
edited by bedevere-bot
Loading

@ZackerySpytz ZackerySpytz requested a review from a team as a code owner April 4, 2019 15:03
@ZackerySpytz
Copy link
Contributor Author

It would be nice to have a unit test for this, but I don't think that's feasable. It seems that the unit test would have to write corrupted data.

@zooba zooba merged commit 56ed864 into python:master Apr 22, 2019
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-12909 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 22, 2019
@ZackerySpytz @miss-islington
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (pytho…
03dbc44 
…nGH-12687)

(cherry picked from commit 56ed864)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 22, 2019
@ZackerySpytz @miss-islington
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (pytho…
c026c8b 
…nGH-12687)

(cherry picked from commit 56ed864)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-12910 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @ZackerySpytz and @zooba, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 56ed86490cb8221c874d432461d77702437f63e5 2.7

miss-islington added a commit that referenced this pull request Apr 22, 2019
@miss-islington @ZackerySpytz
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (GH-12687
7038dee 
)

(cherry picked from commit 56ed864)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
ZackerySpytz added a commit to ZackerySpytz/cpython that referenced this pull request Apr 22, 2019
@ZackerySpytz
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (pytho…
3ab55ac 
…nGH-12687)

(cherry picked from commit 56ed864)
@bedevere-bot
Copy link

GH-12916 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit that referenced this pull request Apr 22, 2019
@ZackerySpytz @miss-islington
[2.7] bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (G…
84efbae 
…H-12687) (GH-12916)

(cherry picked from commit 56ed864)



https://bugs.python.org/issue9194
ned-deily pushed a commit that referenced this pull request May 2, 2019
@miss-islington @ZackerySpytz @ned-deily
bpo-9194: Fix the bounds checking in winreg.c's fixupMultiSZ() (GH-12687
dadc347 
) (GH-12910)

(cherry picked from commit 56ed864)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag left review comments

Assignees

@zooba zooba

Labels
OS-windows skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZackerySpytz @miss-islington @bedevere-bot @berkerpeksag @zooba @the-knights-who-say-ni