gh-127036: Update importlib.util._LazyModule.__getattribute__ to special-case requests for __spec__.
#127038
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `importlib.util._LazyModule` to special-case its `__spec__` attribute so that the regular import machinery requesting that attribute doesn't trigger the full module load.
|
A few things I'm unsure of:
|
I think so since it changes the semantics and someone may have been relying on it.
I think what you already have in the PR suffices as it verifies things are working. |
|
And apologies for taking so long to get to this PR! |
brettcannon
approved these changes
Aug 18, 2025
|
FYI my approval is still gated on a news entry thanks to CI checking for it. |
|
Cheers! Looking at this with fresh eyes, the semantic change definitely warrants more than just a code change. In addition to the news entry, I'll attempt to tweak the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
importlib.util._LazyModuleto special-case its__spec__attribute so that when the regular import machinery requests that attribute, it doesn't trigger the full module load. This will make it easier to useimportlib.util.LazyLoader.