Skip to content

Give poplib.POP3.RPOP a proper docstring #127370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

StanFromIreland
Copy link
Contributor

Please attach the no issue label.

@StanFromIreland
Copy link
Contributor Author

Any core reviewers able to review?

@ZeroIntensity ZeroIntensity requested a review from Eclips4 December 7, 2024 15:20
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eclips4 Eclips4 merged commit 27d0d21 into python:main Dec 7, 2024
54 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 7, 2024
Previously `poplib.POP3.rpop` had a "Not sure what this does" docstring, now it has been fixed.
(cherry picked from commit 27d0d21)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 7, 2024

GH-127721 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 7, 2024
Previously `poplib.POP3.rpop` had a "Not sure what this does" docstring, now it has been fixed.
(cherry picked from commit 27d0d21)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 7, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 7, 2024

GH-127722 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 7, 2024
@Eclips4 Eclips4 changed the title Give RPOP proper docstring Give poplib.POP3.RPOP a proper docstring Dec 7, 2024
Eclips4 pushed a commit that referenced this pull request Dec 7, 2024
Give `poplib.POP3.rpop` a proper docstring (GH-127370)

Previously `poplib.POP3.rpop` had a "Not sure what this does" docstring, now it has been fixed.
(cherry picked from commit 27d0d21)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland StanFromIreland deleted the patch-2 branch December 7, 2024 16:38
Eclips4 pushed a commit that referenced this pull request Dec 7, 2024
Give `poplib.POP3.rpop` a proper docstring (GH-127370)

Previously `poplib.POP3.rpop` had a "Not sure what this does" docstring, now it has been fixed.
(cherry picked from commit 27d0d21)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Previously `poplib.POP3.rpop` had a "Not sure what this does" docstring, now it has been fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants