gh-127552: Remove comment questioning 4-digit restriction for ‘Y’ in datetime.strptime patterns #127590
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
approved these changes
Dec 4, 2024
|
Thanks! |
|
@brettcannon any reason not to backport this (or was it a misclick)? |
I decided it simply wasn't worth it in the end (more churn than necessary). Feel free to if you want to. |
|
I'll just see if we can have an automatic backport. If not, I'll do the backports manually! (tomorrow) |
|
Thanks @bombs-kim for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @bombs-kim for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2024
…Y’ in datetime.strptime patterns (pythonGH-127590) The code has required 4 digits for the year since its inclusion in the stdlib in 2002 (over 22 years ago as of this commit). (cherry picked from commit 51cfa56) Co-authored-by: Beomsoo Kim <beoms424@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2024
…Y’ in datetime.strptime patterns (pythonGH-127590) The code has required 4 digits for the year since its inclusion in the stdlib in 2002 (over 22 years ago as of this commit). (cherry picked from commit 51cfa56) Co-authored-by: Beomsoo Kim <beoms424@gmail.com>
|
GH-127649 is a backport of this pull request to the 3.12 branch. |
|
GH-127650 is a backport of this pull request to the 3.13 branch. |
brettcannon
pushed a commit
that referenced
this pull request
Dec 6, 2024
…‘Y’ in datetime.strptime patterns (GH-127590) GH-127650) gh-127552: Remove comment questioning 4-digit restriction for ‘Y’ in datetime.strptime patterns (GH-127590) The code has required 4 digits for the year since its inclusion in the stdlib in 2002 (over 22 years ago as of this commit). (cherry picked from commit 51cfa56) Co-authored-by: Beomsoo Kim <beoms424@gmail.com>
cfbolz
pushed a commit
that referenced
this pull request
Dec 10, 2024
…‘Y’ in datetime.strptime patterns (GH-127590) (#127649) gh-127552: Remove comment questioning 4-digit restriction for ‘Y’ in datetime.strptime patterns (GH-127590) The code has required 4 digits for the year since its inclusion in the stdlib in 2002 (over 22 years ago as of this commit). (cherry picked from commit 51cfa56) Co-authored-by: Beomsoo Kim <beoms424@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…Y’ in datetime.strptime patterns (python#127590) The code has required 4 digits for the year since its inclusion in the stdlib in 2002 (over 22 years ago as of this commit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the comment questioning 4-digit restriction for ‘Y’ in
datetime.strptimepatterns. The comment is more than 20 years old and practically obsolete at this point.