Skip to content

gh-126004: remove redundant safeguards for codecs handlers tests #127680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 23, 2025
Merged

gh-126004: remove redundant safeguards for codecs handlers tests #127680

merged 5 commits into from
Jan 23, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Dec 6, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 6, 2024
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Dec 6, 2024
encukou
encukou reviewed Dec 6, 2024
View reviewed changes
@picnixz picnixz requested a review from encukou December 28, 2024 10:17
@encukou
Copy link
Member

encukou commented Jan 6, 2025

I'd prefer merging this after the 3 fixes; at that point this would add additional assertions and remove the safe argument.

@picnixz picnixz changed the title gh-126004: allow to mark codecs handlers tests as safe gh-126004: remove safeguards for crashing codecs handlers Jan 23, 2025
@picnixz picnixz changed the title gh-126004: remove safeguards for crashing codecs handlers gh-126004: remove redundant safeguards for codecs handlers Jan 23, 2025
@picnixz picnixz changed the title gh-126004: remove redundant safeguards for codecs handlers gh-126004: remove redundant safeguards for codecs handlers tests Jan 23, 2025
@picnixz picnixz requested a review from vstinner January 23, 2025 13:57
vstinner
vstinner approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz picnixz merged commit cf0b2da into python:main Jan 23, 2025
41 checks passed
@picnixz picnixz deleted the fix/codecs/safe-handlers-126004 branch January 23, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@encukou encukou Awaiting requested review from encukou

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picnixz @encukou @vstinner