Skip to content

[3.12] Add zizmor to pre-commit and fix most findings (GH-127749) #127788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 10, 2024
Merged

[3.12] Add zizmor to pre-commit and fix most findings (GH-127749) #127788

merged 7 commits into from
Dec 10, 2024
+2 −1

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 10, 2024

(cherry picked from commit ae31df3)

@hugovk @AlexWaygood
[3.12] Add zizmor to pre-commit and fix most findings (pythonGH-127749)
63c4b35 
(cherry picked from commit ae31df3)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Dec 10, 2024
Merged
@AlexWaygood AlexWaygood mentioned this pull request Dec 10, 2024
Merged
ezio-melotti
ezio-melotti reviewed Dec 10, 2024
View reviewed changes
@hugovk
Copy link
Member Author

hugovk commented Dec 10, 2024

Thanks @ezio-melotti for fixing this up :)

@hugovk
Copy link
Member Author

hugovk commented Dec 10, 2024

GitHub won't let me merge this right now: "Merge already in progress".

Let's try later...

AlexWaygood
AlexWaygood reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more Windows workflow where I think you need to specify shell: bash. Not sure why it's not failing on this PR but I think we should specify bash anyway:

hugovk and others added 2 commits December 10, 2024 16:08
@hugovk @AlexWaygood
Specify bash shell
220a237 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@hugovk
Merge branch '3.12' into backport-ae31df3-3.12
cea313f
hugovk added a commit to hugovk/cpython that referenced this pull request Dec 10, 2024
@hugovk @AlexWaygood @ezio-melotti
[3.12] Add zizmor to pre-commit and fix most findings (pythonGH-127749)…
381eb04 
… (python#127788)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@hugovk hugovk enabled auto-merge (squash) December 10, 2024 14:29
@hugovk @AlexWaygood
Bash slashes
c324d19 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@hugovk hugovk merged commit 9c54248 into python:3.12 Dec 10, 2024
29 checks passed
@hugovk hugovk deleted the backport-ae31df3-3.12 branch December 10, 2024 14:57
@hugovk hugovk mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @ezio-melotti @AlexWaygood