gh-127865: build failure fix for systems without thread-locals support #127866
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
I think we do need a news entry here. |
ZeroIntensity
approved these changes
Dec 12, 2024
Misc/NEWS.d/next/Build/2024-12-12-14-46-19.gh-issue-127865.hruu1j.rst
Outdated
Show resolved
Hide resolved
44e25de to
4193048
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
98d9d3f to
2a1735c
Compare
colesbury
approved these changes
Dec 12, 2024
|
Thanks @velemas for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 12, 2024
…upport (pythonGH-127866) This PR fixes the build issue introduced by the commit 628f6eb from pythonGH-112207 on systems without thread local support. (cherry picked from commit f823910) Co-authored-by: velemas <10437413+velemas@users.noreply.github.com>
|
GH-127882 is a backport of this pull request to the 3.13 branch. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…upport (pythonGH-127866) This PR fixes the build issue introduced by the commit 628f6eb from pythonGH-112207 on systems without thread local support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build issue introduced by the commit 628f6eb from the PR #112207 on systems without thread-locals support.