Skip to content

gh-127146: Emscripten clean up test suite #127984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2024
Merged

gh-127146: Emscripten clean up test suite #127984

merged 2 commits into from
Dec 17, 2024

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Dec 16, 2024 •
edited by bedevere-app bot
Loading

A lot of these skips are no longer necessary on Emscripten 3.1.74.

@hoodmane
pythongh-127146: Emscripten clean up test suite
4868732 
A lot of these skips are no longer necessary.
@bedevere-app bedevere-app bot mentioned this pull request Dec 16, 2024
Closed
freakboy3742
freakboy3742 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense; I've pushed one minor docstring update so the skip message reflects the skip condition.

@freakboy3742 freakboy3742 enabled auto-merge (squash) December 17, 2024 00:30
@freakboy3742 freakboy3742 merged commit 1183e4c into python:main Dec 17, 2024
44 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Emscripten clean up test suite (python#127984)
9d44349 
Removed test skips that are no longer required as a result of Emscripten updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees
No one assigned
Labels
OS-emscripten skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @freakboy3742