Skip to content

GH-127705: Add debug mode for _PyStackRefs inspired by HPy debug mode #128121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 20, 2024
Merged

GH-127705: Add debug mode for _PyStackRefs inspired by HPy debug mode #128121

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a88c6be
Add (slow) stack ref debug mode to locate stackref leaks and double f…
markshannon Dec 19, 2024
5c621a6
Add PyStackRef_Transfer
markshannon Dec 20, 2024
3d67f2c
Fix stackref leaks
markshannon Dec 20, 2024
8c2a574
Remove unused PyStackRef_Transfer function
markshannon Dec 20, 2024
e51d051
Turn off Py_STACKREF_DEBUG by default
markshannon Dec 20, 2024
7998bc9
Make sure scope of variable covers all uses
markshannon Dec 20, 2024
98706ff
Add news
markshannon Dec 20, 2024
d85c505
Address review comments
markshannon Dec 20, 2024
5eaba5a
Use less type punning
markshannon Dec 20, 2024
efc6cf5
Keep C compilers with poor flow analysis happy
markshannon Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Keep C compilers with poor flow analysis happy
  • Loading branch information
@markshannon
markshannon committed Dec 20, 2024
commit efc6cf50bb5ec3d44c67703534913c5150956bcc
2 changes: 1 addition & 1 deletion Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1811,7 +1811,7 @@ _PyEvalFramePushAndInit_Ex(PyThreadState *tstate, _PyStackRef func,
bool has_dict = (kwargs != NULL && PyDict_GET_SIZE(kwargs) > 0);
PyObject *kwnames = NULL;
_PyStackRef *newargs;
PyObject *const *object_array;
PyObject *const *object_array = NULL;
_PyStackRef stack_array[8];
if (has_dict) {
object_array = _PyStack_UnpackDict(tstate, _PyTuple_ITEMS(callargs), nargs, kwargs, &kwnames);
Expand Down
Loading