Skip to content

gh-128307: support eager_start kwarg in create_eager_task_factory #128306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

gh-128307: support eager_start kwarg in create_eager_task_factory #128306

wants to merge 18 commits into from
+62 −6

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Dec 28, 2024 •
edited by bedevere-app bot
Loading

@graingert graingert changed the title add eager_start to create_task gh-128307: add eager_start to create_task Dec 28, 2024
@bedevere-app bedevere-app bot mentioned this pull request Dec 28, 2024
Open
@graingert graingert changed the title gh-128307: add eager_start to create_task gh-128307: add eager_start kwarg to asyncio.create_task Dec 28, 2024
@graingert graingert force-pushed the add-eager-start-to-create-task branch from c809133 to 2f101b3 Compare December 28, 2024 10:58
graingert
graingert commented Dec 28, 2024
View reviewed changes
@asvetlov
Copy link
Contributor

TaskGroup.create_task() aslo should accept eager_start argument I guess.

@graingert
Copy link
Contributor Author

TaskGroup.create_task() aslo should accept eager_start argument I guess.

yup, it's in I just forgot to add it to the news

graingert
graingert commented Dec 29, 2024
View reviewed changes
graingert
graingert commented Dec 29, 2024
View reviewed changes
@graingert graingert marked this pull request as ready for review December 29, 2024 08:48
@graingert graingert marked this pull request as draft January 21, 2025 05:51
@graingert graingert changed the title gh-128307: add eager_start kwarg to asyncio.create_task gh-128307: add eager_start kwarg to loop.create_task Jan 21, 2025
@graingert graingert force-pushed the add-eager-start-to-create-task branch from 0699ae2 to 7bce401 Compare January 21, 2025 09:26
@graingert graingert changed the title gh-128307: add eager_start kwarg to loop.create_task gh-128307: support eager_start kwarg in create_eager_task_factory Jan 21, 2025
graingert
graingert commented Jan 21, 2025
View reviewed changes
@graingert graingert marked this pull request as ready for review March 25, 2025 07:46
@graingert graingert marked this pull request as draft March 25, 2025 08:08
@graingert
Copy link
Contributor Author

CI failing due to #131709

@graingert graingert marked this pull request as ready for review March 25, 2025 09:02
@graingert
Copy link
Contributor Author

graingert commented Apr 19, 2025 •
edited
Loading

This is currently causing issues with mypy on 3.13.3 and 3.14 because eager_task_factory doesn't support the required **kwargs of create_task: python/typeshed#13687

@hugovk
Copy link
Member

hugovk commented Apr 22, 2025

@asvetlov Hi, the 3.14 beta feature freeze is in two weeks, do you think you can review/merge this before then?

@graingert graingert requested a review from asvetlov April 29, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graingert @asvetlov @hugovk