Skip to content

gh-123681: Check the strftime() behavior at runtime instead of at the compile time #128444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-123681: Check the strftime() behavior at runtime instead of at the compile time #128444

wants to merge 4 commits into from
+44 −163

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 3, 2025 •
edited by bedevere-app bot
Loading

It is needed to support cross-compiling.
Remove macros Py_NORMALIZE_CENTURY and Py_STRFTIME_C99_SUPPORT.

@serhiy-storchaka
pythongh-123681: Check the strftime() behavior at runtime instead of …
0d17190 
…at the compile time

It is needed to support cross-compiling.
Remove macros Py_NORMALIZE_CENTURY and Py_STRFTIME_C99_SUPPORT.
@bedevere-app bedevere-app bot mentioned this pull request Jan 3, 2025
Open
@erlend-aasland
Copy link
Contributor

This PR is not needed anymore. Please see the issue history.

@serhiy-storchaka
Copy link
Member Author

No, it is needed to support cross-compiling. You cannot check the runtime behavior at compile time when cross-compiling.

@erlend-aasland
Copy link
Contributor

No, it is needed to support cross-compiling. You cannot check the runtime behavior at compile time when cross-compiling.

There is no need; we require C99 compliant strftime.

@serhiy-storchaka
Copy link
Member Author

It is not C99 compliant (or at least not Python documentation compliant) on Linux. This is why this workaround was needed at first place.

@erlend-aasland
Copy link
Contributor

It is not C99 compliant (or at least not Python documentation compliant) on Linux. This is why this workaround was needed at first place.

If that was the case, all our Linux build bots and Linux CI would now be broken. However it is not.

@serhiy-storchaka
Copy link
Member Author

I wonder why? I guess because ac_cv_normalize_century=yes if cross-compiling.

@erlend-aasland
Copy link
Contributor

I wonder why?

Because it is C99 compliant, presumably.

I guess because ac_cv_normalize_century=yes if cross-compiling.

ac_cv_normalize_century is not used. It is also set to the empty string, not yes if cross-compiling.

@serhiy-storchaka
Copy link
Member Author

It is used:

cpython/configure.ac

Line 6669 in fa985be

if test "$ac_cv_normalize_century" = yes

And it is set to "yes":

cpython/configure.ac

Line 6668 in fa985be

[ac_cv_normalize_century=yes])])

@erlend-aasland
Copy link
Contributor

Sorry, I misread it as ac_cv_strftime_c99_support.

@picnixz
Copy link
Member

picnixz commented Apr 4, 2025

What's the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @erlend-aasland @picnixz