gh-128552: fix refcycles in eager task creation #128553
Conversation
graingert
commented
Jan 6, 2025
•
- Issue: TaskGroup's task's exception's participate in a reference cycle, via TaskGroup.create_task -> task -> exception and loop.create_task -> task -> exception #128552
…5-01-06-18-41-08.gh-issue-128552.fV-f8j.rst
Misc/NEWS.d/next/Library/2025-01-06-18-41-08.gh-issue-128552.fV-f8j.rst
Outdated
Show resolved
Hide resolved
|
if possible can you add a test which uses weakref to check for refcycle |
| @@ -12,11 +13,6 @@ | |||
|
|
|||
| from test.test_asyncio.utils import await_without_task | |||
|
|
|||
| # To prevent a warning "test altered the execution environment" | |||
There was a problem hiding this comment.
I know this isn't needed as you have changed it to use asyncio.EventLoop but let's keep it for now, it is easy to make a mistake on altering policy and is a pain to fix in CI if it happens without this.
|
|
||
| self.assertIsNone(task_wr()) | ||
| self.assertIsInstance(exc, _Done) | ||
| self.assertListEqual(gc.get_referrers(exc), no_other_refs()) |
There was a problem hiding this comment.
I think it was later changed that coro doesn't hold ref to locals, no_other_refs should not be necessary here.
There was a problem hiding this comment.
Ah its not merged yet #125640
|
Thanks @graingert for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @graingert and @kumaraditya303, I could not cleanly backport this to |
|
Thanks @graingert for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @graingert and @kumaraditya303, I could not cleanly backport this to |
|
GH-128585 is a backport of this pull request to the 3.13 branch. |
(cherry picked from commit 61b9811)
|
GH-128586 is a backport of this pull request to the 3.12 branch. |
|
GH-128586 is a backport of this pull request to the 3.12 branch. |