Skip to content

Update cryptographic primitives code owners. #128747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2025
Merged

Update cryptographic primitives code owners. #128747

merged 4 commits into from
Jan 14, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jan 12, 2025

No description provided.

@picnixz
Copy link
Member Author

picnixz commented Jan 12, 2025

I don't know why the SBOM regeneration fails on Windows (looks like a network issue) :') Guess I'll just try again a bit later.

@AA-Turner
Copy link
Member

It is wasteful to run CI on updates to CODEOWNERS, perhaps we should add it to the exclusions here:

cpython/.github/workflows/reusable-change-detection.yml

Lines 69 to 87 in 5ace717

if [ -z "$GITHUB_BASE_REF" ]; then
echo "run-tests=true" >> "$GITHUB_OUTPUT"
else
git fetch origin "$GITHUB_BASE_REF" --depth=1
# git diff "origin/$GITHUB_BASE_REF..." (3 dots) may be more
# reliable than git diff "origin/$GITHUB_BASE_REF.." (2 dots),
# but it requires to download more commits (this job uses
# "git fetch --depth=1").
#
# git diff "origin/$GITHUB_BASE_REF..." (3 dots) works with Git
# 2.26, but Git 2.28 is stricter and fails with "no merge base".
#
# git diff "origin/$GITHUB_BASE_REF.." (2 dots) should be enough on
# GitHub, since GitHub starts by merging origin/$GITHUB_BASE_REF
# into the PR branch anyway.
#
# https://github.com/python/core-workflow/issues/373
git diff --name-only "origin/$GITHUB_BASE_REF.." | grep -qvE '(\.rst$|^Doc|^Misc|^\.pre-commit-config\.yaml$|\.ruff\.toml$|\.md$|mypy\.ini$)' && echo "run-tests=true" >> "$GITHUB_OUTPUT" || true
fi

A

@AA-Turner AA-Turner mentioned this pull request Jan 12, 2025
Merged
@picnixz
Copy link
Member Author

picnixz commented Jan 12, 2025

I'll wait for #128754 to be merged so that we can test it (I'll make an empty commit to trigger the CI).

gpshead
gpshead reviewed Jan 13, 2025
View reviewed changes
@picnixz picnixz changed the title Add @picnixz to cryptographic primitives code owners. Add @picnixz and @gpshead to cryptographic primitives code owners. Jan 13, 2025
@picnixz picnixz changed the title Add @picnixz and @gpshead to cryptographic primitives code owners. Update cryptographic primitives code owners. Jan 13, 2025
@hugovk
Copy link
Member

hugovk commented Jan 14, 2025

I'll wait for #128754 to be merged so that we can test it (I'll make an empty commit to trigger the CI).

Now merged.

@picnixz
Copy link
Member Author

picnixz commented Jan 14, 2025 •
edited
Loading

It looks like the CI is now in a good shape:

image

I guess we're good to go then.

@hugovk hugovk merged commit eefd4a0 into python:main Jan 14, 2025
23 checks passed
@picnixz picnixz deleted the picnixz-codeowners branch January 14, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead left review comments

@hugovk hugovk hugovk approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@picnixz @AA-Turner @hugovk @gpshead