Skip to content

gh-128017: Make a note that variables that are provided by sys are read-only #128887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2025
Merged

gh-128017: Make a note that variables that are provided by sys are read-only #128887

merged 2 commits into from
Jan 16, 2025

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Jan 15, 2025 •
edited by github-actions bot
Loading

@srinivasreddy
pythongh-128017: Make a note that variables that are provided by :mod…
9729848 
…ule: sys are read-only, Unless explicitly stated otherwise
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Jan 15, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 15, 2025
Closed
@srinivasreddy
Copy link
Contributor Author

Review please @skirpichev @vstinner

@skirpichev skirpichev self-requested a review January 15, 2025 16:20
vstinner
vstinner reviewed Jan 15, 2025
View reviewed changes
vstinner
vstinner approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeroIntensity
Copy link
Member

This seems worth backporting to me. What does everyone think?

@skirpichev skirpichev added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 16, 2025
skirpichev
skirpichev approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it should be backported like most (i.e. when it's applicable) documentation changes.

@vstinner vstinner merged commit 313b96e into python:main Jan 16, 2025
33 checks passed
@miss-islington-app
Copy link

Thanks @srinivasreddy for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 16, 2025
@srinivasreddy @miss-islington
pythongh-128017: Make a note that sys variables are read-only (python…
34dd8bf 
…GH-128887)

(cherry picked from commit 313b96e)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <thatiparthysreenivas@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 16, 2025

GH-128908 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 16, 2025
@srinivasreddy @miss-islington
pythongh-128017: Make a note that sys variables are read-only (python…
ce6a92f 
…GH-128887)

(cherry picked from commit 313b96e)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <thatiparthysreenivas@gmail.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 16, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 16, 2025

GH-128909 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 16, 2025
vstinner pushed a commit that referenced this pull request Jan 16, 2025
@miss-islington @srinivasreddy
[3.12] gh-128017: Make a note that sys variables are read-only (GH-12…
1c85f1b 
…8887) (#128909)

gh-128017: Make a note that sys variables are read-only (GH-128887)
(cherry picked from commit 313b96e)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <thatiparthysreenivas@gmail.com>
@srinivasreddy srinivasreddy deleted the gh_128017 branch January 16, 2025 12:46
hugovk pushed a commit that referenced this pull request Jan 17, 2025
@miss-islington @srinivasreddy
[3.13] gh-128017: Make a note that sys variables are read-only (GH-12…
9974e71 
…8887) (#128908)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <thatiparthysreenivas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@skirpichev skirpichev skirpichev approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srinivasreddy @ZeroIntensity @vstinner @skirpichev @StanFromIreland