Skip to content

[3.12] gh-58956: Fix a frame refleak in bdb (GH-128190) #128953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

gaogaotiantian
Copy link
Member

(cherry picked from commit 767c89b)

Co-authored-by: Tian Gao gaogaotiantian@hotmail.com

@gaogaotiantian
Copy link
Member Author

Hey @iritkatriel , had to ping you again because this is related to #125549. It's a bit convoluted but basically this is fixing something that does not exist. This fix is safe, passes the test but it does not really do anything, because enterframe is never assigned. However, with this "fix", we can safely merge #125549 without leaking any frames. The order could be either way but hopefully by merging them closely with each other we don't need to worry about that.

@gaogaotiantian gaogaotiantian merged commit f45da82 into python:3.12 Jan 17, 2025
31 checks passed
@gaogaotiantian gaogaotiantian deleted the backport-767c89b-3.12 branch January 17, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants