gh-128998: Fix indentation of numbered list and literal block #128999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
approved these changes
Jan 18, 2025
AA-Turner
approved these changes
Jan 18, 2025
|
Thanks @rffontenelle for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 18, 2025
…ythonGH-128999) (cherry picked from commit e8092e5) Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-129000 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 18, 2025
…ythonGH-128999) (cherry picked from commit e8092e5) Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-129001 is a backport of this pull request to the 3.12 branch. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 21, 2025
…ython#128999) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bad indentation in numbered list and adds one missing whitespace in literal block, to fix translated documentation generation.
The lack of indentation was turning these (supposed-to-be) numbered list items into simple paragraphs. While no error message pops up in English docs, building translation docs will emit:
Fixing indentation was enough, though. Now, translated build will emit:
Adding one extra whitespace to the literal block (to make four-whitespaces indentation, instead of three) solves the whole thing
In the left is today's faq/programming.html, in right is my patch:
📚 Documentation preview 📚: https://cpython-previews--128999.org.readthedocs.build/