Skip to content

gh-71339: Use new assertion methods in test_capi #129053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

gh-71339: Use new assertion methods in test_capi #129053

merged 1 commit into from
Jan 20, 2025

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 20, 2025 •
edited by bedevere-app bot
Loading

They provide better error report.

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Jan 20, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 20, 2025
Closed
vstinner
vstinner approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit a30277a into python:main Jan 20, 2025
47 checks passed
@serhiy-storchaka serhiy-storchaka deleted the test_capi-asserts branch January 20, 2025 12:32
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
@serhiy-storchaka @srinivasreddy
pythongh-71339: Use new assertion methods in test_capi (pythonGH-129053)
4419870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @vstinner