Skip to content

gh-91048: Improve example in asyncio-graph.rst doc #129224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

gh-91048: Improve example in asyncio-graph.rst doc #129224

merged 1 commit into from
Jan 23, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 23, 2025 •
edited by bedevere-app bot
Loading

I propose adding an explicit name, because it is not clear what "Task-1" and "Task-2" are. Now with this explicit name it is more readable.

📚 Documentation preview 📚: https://cpython-previews--129224.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting core review docs Documentation in the Doc dir skip news labels Jan 23, 2025
@picnixz picnixz changed the title Improve example in asyncio-graph.rst doc gh-91048: Improve example in asyncio-graph.rst doc Jan 23, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 23, 2025
Open
StanFromIreland
StanFromIreland approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, this will make it clearer for people less familiar with tasks.

@kumaraditya303 kumaraditya303 merged commit c05a851 into python:main Jan 23, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @kumaraditya303 @StanFromIreland @picnixz