Fix ASCII position in description of curses.ascii.rst #129300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -148,7 +148,7 @@ C library: | |||
|
|
|||
| .. function:: ispunct(c) | |||
|
|
|||
| Checks for any printable ASCII character which is not a space or an alphanumeric | |||
| Checks for any ASCII printable character which is not a space or an alphanumeric | |||
There was a problem hiding this comment.
Suggested change
| Checks for any ASCII printable character which is not a space or an alphanumeric | |
| Checks for any printable ASCII character which is not a space or an alphanumeric |
I think the current state here is fine, it reads normally.
Other change however is an error and I think it should be merged.
There was a problem hiding this comment.
I agree it reads normally, but did you see that other descriptions are like "any ASCII printable character" and "an ASCII uppercase letter" ? Keeping this as "any printable ASCII character" would make it sort of uneven
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the "ASCII" word in these descriptions are in the same place as in other nearby descriptions: an/any ASCII something letter/character. For instance,
any ASCII printable characterandan ASCII uppercase letter.📚 Documentation preview 📚: https://cpython-previews--129300.org.readthedocs.build/