Skip to content

gh-112075: Remove critical section in dict.get #129336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2025
Merged

gh-112075: Remove critical section in dict.get #129336

merged 3 commits into from
Jan 28, 2025

Conversation

eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Jan 27, 2025 •
edited by bedevere-app bot
Loading

  • The dict.get implementation uses _Py_dict_lookup_threadsafe which is thread-safe, so we remove the critical section from the argument clinic.
  • Add a test for concurrent dict get and set operations

@bedevere-app bedevere-app bot mentioned this pull request Jan 27, 2025
Closed
@colesbury colesbury enabled auto-merge (squash) January 28, 2025 21:33
@colesbury
Copy link
Contributor

Thanks!

@colesbury colesbury merged commit 64c417d into python:main Jan 28, 2025
40 checks passed
@eendebakpt eendebakpt mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eendebakpt @colesbury