Skip to content

gh-129345: null check for indent syslogmodule #129348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 29, 2025
Merged

gh-129345: null check for indent syslogmodule #129348

merged 4 commits into from
Jan 29, 2025
+2 −1

Conversation

wooffie
Copy link
Contributor

@wooffie wooffie commented Jan 27, 2025 •
edited by bedevere-app bot
Loading

Added check for ident

@ghost
Copy link

ghost commented Jan 27, 2025 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Jan 27, 2025
Closed
@bedevere-app
Copy link

bedevere-app bot commented Jan 27, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

tomasr8
tomasr8 reviewed Jan 27, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Jan 27, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Jan 27, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

ZeroIntensity
ZeroIntensity reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This is technically user-facing, so we need a blurb entry.
  • We can probably make a test case for this. (See my comment on the issue.)

@wooffie @tomasr8
Update Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issu…
8cdf5ca 
…e-129345.uOjkML.rst

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@kumaraditya303 kumaraditya303 merged commit 25cf79a into python:main Jan 29, 2025
45 checks passed
@kumaraditya303 kumaraditya303 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 29, 2025
@miss-islington-app
Copy link

Thanks @wooffie for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @wooffie for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 29, 2025
@wooffie @miss-islington
pythongh-129345: null check for indent syslogmodule (pythonGH-129348)
e397de5 
(cherry picked from commit 25cf79a)

Co-authored-by: Burkov Egor <xwooffie@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 29, 2025

GH-129442 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 29, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 29, 2025
@wooffie @miss-islington
pythongh-129345: null check for indent syslogmodule (pythonGH-129348)
46db206 
(cherry picked from commit 25cf79a)

Co-authored-by: Burkov Egor <xwooffie@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 29, 2025

GH-129443 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 29, 2025
@kumaraditya303
Copy link
Contributor

We can probably make a test case for this. (See my comment on the issue.)

Ah, I didn't see this, the fix is trivial so test isn't that important either.

@ZeroIntensity
Copy link
Member

Yeah, it's not that important. I'd welcome a follow-up with a test case, though @wooffie

Yhg1s pushed a commit that referenced this pull request Feb 3, 2025
@miss-islington @wooffie
[3.12] gh-129345: null check for indent syslogmodule (GH-129348) (#12…
6985b4b 
…9443)

gh-129345: null check for indent syslogmodule (GH-129348)
(cherry picked from commit 25cf79a)

Co-authored-by: Burkov Egor <xwooffie@gmail.com>
Yhg1s pushed a commit that referenced this pull request Feb 3, 2025
@miss-islington @wooffie
[3.13] gh-129345: null check for indent syslogmodule (GH-129348) (#12…
de27372 
…9442)

gh-129345: null check for indent syslogmodule (GH-129348)
(cherry picked from commit 25cf79a)

Co-authored-by: Burkov Egor <xwooffie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wooffie @kumaraditya303 @ZeroIntensity @tomasr8