Skip to content

[3.10] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171) #129440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025
Merged

[3.10] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171) #129440

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2491831
[3.11] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-129171)
vstinner Jan 23, 2025
8532e37
gh-119461: Restore the testSocket VSOCK skipUnless removed by PR #119…
gpshead Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
gh-119461: Restore the testSocket VSOCK skipUnless removed by PR #119465 
 (#129561)

Restore the skipUnless removed by #119465.

This test can only pass on virtual machines, not actual machines.

actual machines see:

```
    self.cli.connect((cid, VSOCKPORT))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
OSError: [Errno 19] No such device
```

Reproduced on (Linux) Ubuntu 24.04.1 running 6.8.0-52-generic.
  • Loading branch information
@gpshead @encukou
gpshead authored and encukou committed Feb 3, 2025
commit 8532e376d51f26df7bdce19bd3eb0c78f442925c
2 changes: 2 additions & 0 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,8 @@ def clientTearDown(self):
@unittest.skipIf(fcntl is None, "need fcntl")
@unittest.skipUnless(HAVE_SOCKET_VSOCK,
'VSOCK sockets required for this test.')
@unittest.skipUnless(get_cid() != 2, # VMADDR_CID_HOST
"This test can only be run on a virtual guest.")
class ThreadedVSOCKSocketStreamTest(unittest.TestCase, ThreadableTest):

def __init__(self, methodName='runTest'):
Expand Down
Loading