Skip to content

gh-126609: Revert Availability Directive changes #129480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

gh-126609: Revert Availability Directive changes #129480

wants to merge 8 commits into from

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Jan 30, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 30, 2025
Closed
m-aciek
m-aciek suggested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@m-aciek m-aciek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd not revert the move, but just the changes that were made in the directive class.

@StanFromIreland
Copy link
Contributor Author

@m-aciek Reverted just changes

@StanFromIreland StanFromIreland changed the title gh-126609: Revert Availability Directive move gh-126609: Revert Availability Directive changes Jan 30, 2025
@m-aciek
Copy link
Contributor

m-aciek commented Jan 30, 2025

I've opened a more minimal revert: #129482

@StanFromIreland
Copy link
Contributor Author

Closed for #129482

@StanFromIreland StanFromIreland deleted the revert-avail-move branch January 30, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@m-aciek m-aciek Awaiting requested review from m-aciek

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanFromIreland @m-aciek